Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rules_go is a non-dev dep at HEAD #554

Merged
merged 1 commit into from Sep 27, 2023
Merged

chore: rules_go is a non-dev dep at HEAD #554

merged 1 commit into from Sep 27, 2023

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Sep 27, 2023

This ensures if a bzlmod user were to fetch bazel-lib with a SHA or a git_repository, they don't need to patch our repo (similar to how CI was doing it) in order to build the tools/ from head

This ensures if you get a SHA of bazel-lib you build the tools/ from head
@alexeagle alexeagle merged commit 14d6c50 into main Sep 27, 2023
50 checks passed
@alexeagle alexeagle deleted the bcr_patch branch September 27, 2023 16:01
@kormide
Copy link
Member

kormide commented Sep 27, 2023

Would be nice if we could generate the patch and use a write_source_files to keep it updated. Otherwise we'll only know it failed when the BCR release fails. If that proves difficult to do, perhaps it's a good motivation for publish-to-bcr to support a regex replace like you originally suggested 🤔

@alexeagle
Copy link
Member Author

I'll just add a CI step that runs patch -p1 < .bcr/patches/* to catch that on CI without adding complexity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants