Avoid expanding mtree spec during analysis phase #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
reviewed
Oct 5, 2023
lib/private/tar.bzl
Outdated
| content.set_param_file_format("multiline") | ||
| content.add_all(ctx.files.srcs, map_each = _default_mtree_line) | ||
| # TODO(zbarsky): do we need this blank line? Tests pass on OSX without it for me. | ||
| #content.add("") |
There was a problem hiding this comment.
this was here to ensure the last line of the file has a trailing newline, but I think the multiline param_file_format is doing it so you're right it's unneeded. And yeah I trust our tests pretty well :)
remove comment and unused code
alexeagle
added a commit
that referenced
this pull request
Oct 8, 2023
* Avoid expanding mtree spec during analysis phase * Update tar.bzl remove comment and unused code --------- Co-authored-by: Alex Eagle <alex@aspect.dev>
alexeagle
added a commit
that referenced
this pull request
Dec 23, 2023
* Avoid expanding mtree spec during analysis phase * Update tar.bzl remove comment and unused code --------- Co-authored-by: Alex Eagle <alex@aspect.dev>
gregmagolan
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Avoid expanding mtree spec during analysis phase * Update tar.bzl remove comment and unused code --------- Co-authored-by: Alex Eagle <alex@aspect.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing what CI thinks, I didn't see why we need the empty line at the end of the file
Type of change
- Performance (a code change that improves performance)
For changes visible to end-users
Test plan
- Covered by existing test cases