Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run gazelle #584

Merged
merged 1 commit into from
Oct 5, 2023
Merged

chore: run gazelle #584

merged 1 commit into from
Oct 5, 2023

Conversation

alexeagle
Copy link
Member

Also delete the local_config_platform workaround for bazel 5 which made our docs setup complex

Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

For changes visible to end-users

  • Breaking change (this change will force users to change their own code or config)

bazel-lib no longer provides a workaround for Bazel 5 users to get a @local_config_platform repository.
If you need this, you must upgrade to Bazel 6.

Test plan

  • Covered by existing test cases

@alexeagle
Copy link
Member Author

I think we should drop support for Bazel 5 altogether.

Also delete the local_config_platform workaround for bazel 5 which made our docs setup complex
@alexeagle alexeagle merged commit 6a4381b into 2.x Oct 5, 2023
36 of 37 checks passed
@alexeagle alexeagle deleted the bzl_libraries branch October 5, 2023 21:22
alexeagle added a commit that referenced this pull request Oct 8, 2023
Also delete the local_config_platform workaround for bazel 5 which made our docs setup complex
alexeagle added a commit that referenced this pull request Oct 10, 2023
Related to #584 which removed a Bazel 5 workaround
alexeagle added a commit that referenced this pull request Oct 10, 2023
Related to #584 which removed a Bazel 5 workaround
alexeagle added a commit that referenced this pull request Oct 10, 2023
Related to #584 which removed a Bazel 5 workaround
alexeagle added a commit that referenced this pull request Dec 23, 2023
Also delete the local_config_platform workaround for bazel 5 which made our docs setup complex
thesayyn pushed a commit that referenced this pull request Mar 27, 2024
Also delete the local_config_platform workaround for bazel 5 which made our docs setup complex

(cherry picked from commit 6a4381b)
thesayyn pushed a commit that referenced this pull request Mar 27, 2024
Also delete the local_config_platform workaround for bazel 5 which made our docs setup complex

(cherry picked from commit 6a4381b)
thesayyn added a commit that referenced this pull request Mar 27, 2024
* chore: run gazelle (#584)

Also delete the local_config_platform workaround for bazel 5 which made our docs setup complex

(cherry picked from commit 6a4381b)

* chore: test against bazel 7.0.0 (#713)

(cherry picked from commit 5aaa785)

---------

Co-authored-by: Alex Eagle <alex@aspect.dev>
Co-authored-by: Greg Magolan <gmagolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants