refactor: remove to_workspace_path and to_manifest_path from paths #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
changed the title
gregmagolan
force-pushed
the
remove_to_workspace_path
branch
from
5dc7185
to
a4b2f12
Compare
alexeagle
approved these changes
Oct 6, 2023
alexeagle
pushed a commit
that referenced
this pull request
Oct 8, 2023
alexeagle
pushed a commit
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes deprecated
to_workspace_pathandto_manifest_path. These functions were renamed toto_repository_relative_pathandto_rlocation_pathfor clarity. The old names were kept around for backward compat in 1.x. This was a planned breaking change for the 2.0 release.BREAKING CHANGES
to_workspace_pathhelper function is removed frompaths. Usepaths.to_repository_relative_pathinstead.to_manifest_pathhelper function is removed frompaths. Usepaths.to_rlocation_pathinstead.