Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add windows binaries #610

Merged
merged 6 commits into from
Oct 10, 2023
Merged

chore: add windows binaries #610

merged 6 commits into from
Oct 10, 2023

Conversation

alexeagle
Copy link
Member

No description provided.

@alexeagle
Copy link
Member Author

Note, it's not very hermetic, the bsdtar.exe still requires some DLLs to be on the system.
https://buildkite.com/bazel/bazel-bazel-examples/builds/2166#018b1b6c-5866-46ee-a5ab-fe2dfb3c3446 fails with STATUS_DLL_NOT_FOUND.

Going to merge anyway as it's green for us! I worked hard on Windows today and deserve a break :)

@alexeagle alexeagle merged commit eda4929 into 2.x Oct 10, 2023
61 checks passed
@alexeagle alexeagle deleted the windows-tar branch October 10, 2023 21:13
alexeagle added a commit that referenced this pull request Dec 23, 2023
* chore: add windows binaries

* chore: fix/exclude windows brokenness

* chore: try to see why diff tests fail on windows

* fix: rm bazelisk rc again for windows

* fix: try our own diff_test

* chore: use only our own diff_test
gregmagolan pushed a commit that referenced this pull request Mar 23, 2024
* chore: add windows binaries

* chore: fix/exclude windows brokenness

* chore: try to see why diff tests fail on windows

* fix: rm bazelisk rc again for windows

* fix: try our own diff_test

* chore: use only our own diff_test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants