Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove bazel5 presets #614

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

kormide
Copy link
Member

@kormide kormide commented Oct 10, 2023

Because bazel-lib 2.0 has a minimum Bazel compatibility set to 6.0.0.

Type of change

  • Chore (any other change that doesn't affect source or test files, such as configuration)

Test plan

  • Covered by existing test cases

@alexeagle
Copy link
Member

@kormide can you green this up so we can merge?

ERROR: /home/runner/work/bazel-lib/bazel-lib/lib/tests/bazelrc_presets/subset/BUILD.bazel:3:29: no such target '//.aspect/bazelrc:bazel6.bazelrc': target 'bazel6.bazelrc' not declared in package '.aspect/bazelrc' defined by /home/runner/work/bazel-lib/bazel-lib/.aspect/bazelrc/BUILD.bazel (did you mean 'bazel7.bazelrc'? Tip: use `query "//.aspect/bazelrc:*"` to see all the targets in that package) and referenced by '//lib/tests/bazelrc_presets/subset:update_aspect_bazelrc_presets_0_test'

@alexeagle alexeagle removed their request for review October 13, 2023 18:53
@kormide kormide force-pushed the remove-b5-preset branch 4 times, most recently from d77b34b to 1cec86d Compare October 16, 2023 01:16
@kormide kormide merged commit 5077d5a into aspect-build:main Oct 16, 2023
25 checks passed
alexeagle pushed a commit that referenced this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants