Use coreutils toolchain for copy_file action #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
force-pushed
the
zbarsky/coreutils-cp
branch
2 times, most recently
from
12add9a
to
307ea0a
Compare
dzbarsky
commented
Oct 12, 2023
gregmagolan
force-pushed
the
zbarsky/coreutils-cp
branch
from
307ea0a
to
f09c60a
Compare
|
Rebased and resolved conflict |
gregmagolan
force-pushed
the
zbarsky/coreutils-cp
branch
from
28d07ee
to
6a5d3d7
Compare
gregmagolan
force-pushed
the
zbarsky/coreutils-cp
branch
from
6a5d3d7
to
73ebe50
Compare
|
FYI, there was an issue with darwin arm64 binaries for coreutils. #519 |
So this PR will break copy_file on M1s until that is resolved? |
yes, if you don't have rosetta turned on |
|
Roger. We'll have to wait until that is resolved then before we can land this one. |
|
Let's see how they feel about uutils/coreutils#5523 |
thesayyn
approved these changes
Nov 14, 2023
kormide
approved these changes
Nov 14, 2023
kormide
force-pushed
the
zbarsky/coreutils-cp
branch
from
6eb663b
to
15e7913
Compare
This was referenced Nov 14, 2023
This was referenced Nov 14, 2023
kormide
added a commit
to kormide/bazel-lib
that referenced
this pull request
Nov 15, 2023
This reverts commit 01ca8f9.
alexeagle
pushed a commit
that referenced
this pull request
Dec 23, 2023
refactor: use coreutils toolchain for copy_file action --------- Co-authored-by: Greg Magolan <greg@aspect.dev> Co-authored-by: Derek Cormier <derek@aspect.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the coreutils toolchain rather than bash/batch scripts to perform the copy.
Type of change
Refactor (a code change that neither fixes a bug or adds a new feature)**
Relevant documentation has been updated
Suggested release notes are provided below:
Breaking change (this change will force users to change their own code or config)
Might require toolchain registration where previously it wasn't needed, if users did their own toolchain registration instead of calling
aspect_bazel_lib_register_toolchainsas the docs recommendTest plan