feat: expose toolchains used for copy actions #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
force-pushed
the
copy-action-toolchains-2.x
branch
6 times, most recently
from
14f6850
to
eb6ae4b
Compare
kormide
commented
Nov 16, 2023
kormide
force-pushed
the
copy-action-toolchains-2.x
branch
from
eb6ae4b
to
cb5bdc1
Compare
alexeagle
approved these changes
Nov 16, 2023
alexeagle
pushed a commit
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For downstream rulesets to use bazel-lib 1.x and 2.x, some additions/fixes need to be included in the next 2.0 release. These include:
Type of change
Test plan
Manual testing against against rules_js and rules_ts overriden to point to this PR.