Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add an e2e to test copy actions #665

Merged
merged 1 commit into from
Nov 19, 2023
Merged

chore: add an e2e to test copy actions #665

merged 1 commit into from
Nov 19, 2023

Conversation

kormide
Copy link
Member

@kormide kormide commented Nov 19, 2023 •
edited

An e2e like this would have caught the regression where coreutils was required for copy actions.

Type of change

  • Chore (any other change that doesn't affect source or test files, such as configuration)

Test plan

  • New test cases added

@kormide kormide marked this pull request as ready for review November 19, 2023 01:15
alexeagle
alexeagle approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@kormide kormide merged commit 2433bae into aspect-build:main Nov 19, 2023
32 checks passed
@kormide kormide deleted the copy-action-e2e branch November 21, 2023 18:51
alexeagle pushed a commit that referenced this pull request Dec 23, 2023
@kormide @alexeagle
chore: add an e2e to test copy actions (#665)
9d33107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kormide @alexeagle