Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: give version.bzl public visibility #670

Merged
merged 1 commit into from Nov 22, 2023

Conversation

kormide
Copy link
Member

@kormide kormide commented Nov 22, 2023

The version is exposed in 2.x. Backporting it here so we can switch on it to support bazel-lib 1.x/2.x in downstream rulesets.

Type of change

  • New feature or functionality (change which adds functionality)

@kormide kormide changed the base branch from main to 1.x November 22, 2023 18:32
@kormide kormide marked this pull request as ready for review November 22, 2023 18:51
@kormide kormide changed the title Version visibility feat: give version.bzl public visibility Nov 22, 2023
@kormide kormide merged commit f379589 into aspect-build:1.x Nov 22, 2023
1 check passed
alexeagle pushed a commit to aspect-build/rules_py that referenced this pull request Feb 2, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| aspect_bazel_lib | bazel_dep | minor | `1.38.1` -> `1.40.0` |
| [aspect_bazel_lib](https://togithub.com/aspect-build/bazel-lib) |
http_archive | minor | `v1.38.1` -> `v1.40.0` |

---

### Release Notes

<details>
<summary>aspect-build/bazel-lib (aspect_bazel_lib)</summary>

###
[`v1.40.0`](https://togithub.com/aspect-build/bazel-lib/releases/tag/v1.40.0)

[Compare
Source](https://togithub.com/aspect-build/bazel-lib/compare/v1.39.1...v1.40.0)

#### Using Bzlmod with Bazel 6:

1.  Enable with `common --enable_bzlmod` in `.bazelrc`.
2.  Add to your `MODULE.bazel` file:

```starlark
bazel_dep(name = "aspect_bazel_lib", version = "1.40.0")
```

> Read more about bzlmod: <https://blog.aspect.dev/bzlmod>

#### Using WORKSPACE

Paste this snippet into your `WORKSPACE` file:

```starlark
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "aspect_bazel_lib",
    sha256 = "f6ef68871d206cf8f5f4eea83d26a366563a631b020afe1da2f838a9bff035c0",
    strip_prefix = "bazel-lib-1.40.0",
    url = "https://github.com/aspect-build/bazel-lib/releases/download/v1.40.0/bazel-lib-v1.40.0.tar.gz",
)

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "aspect_bazel_lib_dependencies")

aspect_bazel_lib_dependencies()

```

Optional toolchains:

```starlark

### Register the following toolchain to use jq

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "register_jq_toolchains")

register_jq_toolchains()

### Register the following toolchain to use yq

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "register_yq_toolchains")

register_yq_toolchains()
```

**Full Changelog**:
aspect-build/bazel-lib@v1.39.1...v1.40.0

###
[`v1.39.1`](https://togithub.com/aspect-build/bazel-lib/releases/tag/v1.39.1)

[Compare
Source](https://togithub.com/aspect-build/bazel-lib/compare/v1.39.0...v1.39.1)

#### Using Bzlmod with Bazel 6:

1.  Enable with `common --enable_bzlmod` in `.bazelrc`.
2.  Add to your `MODULE.bazel` file:

```starlark
bazel_dep(name = "aspect_bazel_lib", version = "1.39.1")
```

> Read more about bzlmod: <https://blog.aspect.dev/bzlmod>

#### Using WORKSPACE

Paste this snippet into your `WORKSPACE` file:

```starlark
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "aspect_bazel_lib",
    sha256 = "5e9588d8407a576771f1e0d8956f541f78610f1b6e4cca29af2a096fccfe3b24",
    strip_prefix = "bazel-lib-1.39.1",
    url = "https://github.com/aspect-build/bazel-lib/releases/download/v1.39.1/bazel-lib-v1.39.1.tar.gz",
)

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "aspect_bazel_lib_dependencies")

aspect_bazel_lib_dependencies()

```

Optional toolchains:

```starlark

### Register the following toolchain to use jq

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "register_jq_toolchains")

register_jq_toolchains()

### Register the following toolchain to use yq

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "register_yq_toolchains")

register_yq_toolchains()
```

**Full Changelog**:
aspect-build/bazel-lib@v1.39.0...v1.39.1

###
[`v1.39.0`](https://togithub.com/aspect-build/bazel-lib/releases/tag/v1.39.0)

[Compare
Source](https://togithub.com/aspect-build/bazel-lib/compare/v1.38.1...v1.39.0)

#### Using Bzlmod with Bazel 6:

1.  Enable with `common --enable_bzlmod` in `.bazelrc`.
2.  Add to your `MODULE.bazel` file:

```starlark
bazel_dep(name = "aspect_bazel_lib", version = "1.39.0")
```

> Read more about bzlmod: <https://blog.aspect.dev/bzlmod>

#### Using WORKSPACE

Paste this snippet into your `WORKSPACE` file:

```starlark
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "aspect_bazel_lib",
    sha256 = "4d6010ca5e3bb4d7045b071205afa8db06ec11eb24de3f023d74d77cca765f66",
    strip_prefix = "bazel-lib-1.39.0",
    url = "https://github.com/aspect-build/bazel-lib/releases/download/v1.39.0/bazel-lib-v1.39.0.tar.gz",
)

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "aspect_bazel_lib_dependencies")

aspect_bazel_lib_dependencies()

```

Optional toolchains:

```starlark

### Register the following toolchain to use jq

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "register_jq_toolchains")

register_jq_toolchains()

### Register the following toolchain to use yq

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "register_yq_toolchains")

register_yq_toolchains()
```

#### What's Changed

- feat: give version.bzl public visibility by
[@&#8203;kormide](https://togithub.com/kormide) in
[aspect-build/bazel-lib#670

**Full Changelog**:
aspect-build/bazel-lib@v1.38.1...v1.39.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/aspect-build/rules_py).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants