Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isolate rules_lint dev dependency usage into its own Bazel package #687

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Dec 11, 2023

Fixes #686.

This regressed when rules_lint was brought in for format.


Type of change

  • Bug fix (change which fixes an issue)

Test plan

Why wasn't this caught in CI and in bzlmod presumbit in #681 ?!?

@alexeagle alexeagle merged commit 13aefd6 into main Dec 11, 2023
70 checks passed
@alexeagle alexeagle deleted the isolated_dev_dep branch December 11, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Upgrading to 2.0.3 without bzlmod fails due to missing @aspect_rules_lint
2 participants