Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tar): propagate testonly attr to mtree_spec #691

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix(tar): propagate testonly attr to mtree_spec #691

merged 1 commit into from
Dec 13, 2023

Conversation

alexeagle
Copy link
Member

Not sure if it's worth the time to add an analysis_test for something this simple.

thesayyn
thesayyn approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the rulesets that uses macros in the ecosystem suffers from this... wish bazel would automatically adds well knowns to expansion.

@alexeagle alexeagle merged commit 303779e into main Dec 13, 2023
62 checks passed
@alexeagle alexeagle deleted the testonly branch December 13, 2023 23:21
gregmagolan pushed a commit that referenced this pull request Mar 23, 2024
@alexeagle @gregmagolan
fix(tar): propagate testonly attr to mtree_spec (#691)
cd7c55c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexeagle @thesayyn