Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #697: use to_repository_relative_path in mtree_spec #696

Merged
merged 8 commits into from
Dec 20, 2023
Merged

fix #697: use to_repository_relative_path in mtree_spec #696

merged 8 commits into from
Dec 20, 2023

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Dec 18, 2023 •
edited

Fixes #697.

@gzm0
Copy link
Contributor Author

gzm0 commented Dec 18, 2023

I'll try and work this into a proper fix, but just wanted to get it out there to get any thoughts / feedback.

@gzm0 gzm0 changed the title WIP: Reproduction for mtree_spec behaving different in other repo fix #697: use to_repository_relative_path in mtree_spec Dec 18, 2023
@gzm0 gzm0 marked this pull request as ready for review December 18, 2023 16:14
alexeagle
alexeagle reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right to me. I just wonder if it's worth creating a new e2e test for this, given those get expensive on CI as they accumulate, vs just adding an analysis test that's like a unit test for the starlark code

@gzm0
Replace e2e test with a normal test
3b8a1fe 
To do this, we somewhat abuse the skylib dependency, but that's
probalby OK.
@gzm0
Copy link
Contributor Author

gzm0 commented Dec 20, 2023

Good point. I managed to make a "normal" test (still not just analysis test though) by using the LICENSE file exported by skylib. This tests the same thing, but is of course much more lightweight.

PTAL.

@gzm0 gzm0 requested a review from alexeagle December 20, 2023 05:22
alexeagle
alexeagle approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!!

@alexeagle alexeagle merged commit 8d805e1 into aspect-build:main Dec 20, 2023
32 checks passed
@gzm0 gzm0 deleted the mtree-external branch December 21, 2023 06:32
gregmagolan pushed a commit that referenced this pull request Mar 23, 2024
@gzm0 @gregmagolan
fix #697: use to_repository_relative_path in mtree_spec (#696)
d9c7cb7 
* Reproduction for mtree_spec behaving different in other repo

* Fix the bug (but not the test)

* Fix the test

* Rename mtree_spec e2e dir to tar

* Fix bzlmod tests

* Remove unnecessary skylib dependency from e2e repos

* Add e2e tests to matrix

* Replace e2e test with a normal test

To do this, we somewhat abuse the skylib dependency, but that's
probalby OK.
gregmagolan pushed a commit that referenced this pull request Mar 23, 2024
@gzm0 @gregmagolan
fix #697: use to_repository_relative_path in mtree_spec (#696)
2ce4574 
* Reproduction for mtree_spec behaving different in other repo

* Fix the bug (but not the test)

* Fix the test

* Rename mtree_spec e2e dir to tar

* Fix bzlmod tests

* Remove unnecessary skylib dependency from e2e repos

* Add e2e tests to matrix

* Replace e2e test with a normal test

To do this, we somewhat abuse the skylib dependency, but that's
probalby OK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: mtree_spec yield different result when built in an external repository
2 participants
@gzm0 @alexeagle