feat: implement bats test runner #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
reviewed
Dec 20, 2023
| @@ -103,6 +104,81 @@ def register_tar_toolchains(name = DEFAULT_TAR_REPOSITORY, register = True): | |||
| user_repository_name = name, | |||
| ) | |||
|
|
|||
| DEFAULT_BATS_REPOSITORY = "bats" | |||
|
|
|||
| DEFAULT_BATS_CORE_VERSION = "v1.10.0" | |||
There was a problem hiding this comment.
We don't want to make all these the latest version?
There was a problem hiding this comment.
these are all latest versions as of today.
There was a problem hiding this comment.
I mean doing = BATS_CORE_VERSIONS[-1] or whatever the syntax would be...
|
Did you try this out in silo? |
Not directly, just added usages there as tests here. |
thesayyn
commented
Dec 20, 2023
kormide
reviewed
Dec 20, 2023
kormide
reviewed
Dec 20, 2023
|
@jmmv do you have any input about this as a comparison with https://github.com/jmmv/rules_shtk/ ? |
thesayyn
force-pushed
the
bats_runner
branch
from
277c888
to
78c72fc
Compare
|
before i merge, let me try this on rules_oci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Test plan