chore: add bzlmod test matrix #749
Merged
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be best for me to manually ignore the failing tests for now so that as I update the bzlmod api I can un-ignore them, rather than leaving this testing until the end. |
alexeagle
reviewed
Jan 3, 2023
My assumption was that we would keep the Yeah, with this we wouldn't need |
|
Excluded the failing tests so that I can include them individually as I update the bzlmod api. |
gregmagolan
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of: #644
This adds a test matrix vector that exercises bzlmod for all unit and e2e tests. This way we can test that all of our e2es work under bzlmod and can keep the WORKSPACE/bzlmod apis in sync.
Currently this will fail because we need to add
MODULE.bazelfiles to each e2e and actually fix the bzlmod api. The module files should be ignored during non-bzlmod test runs.I can either ignore failing tests for now, or we can keep this PR open until all are fixed.