Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate aws-sdk instrumentation #196

Merged
merged 3 commits into from Nov 12, 2021
Merged

chore: deprecate aws-sdk instrumentation #196

merged 3 commits into from Nov 12, 2021

Conversation

blumamir
Copy link
Contributor

@blumamir blumamir commented Nov 12, 2021 •
edited

related to #194 and #169

@blumamir blumamir requested a review from a team as a code owner November 12, 2021 06:54
YanivD
YanivD approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@YanivD YanivD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blumamir
There's another reference in conventions.md:

aws-sdk is using http for the internal RPC requests to various services

@blumamir
Copy link
Contributor Author

@blumamir There's another reference in conventions.md:

aws-sdk is using http for the internal RPC requests to various services

it's just an example which is still valid, not a reference

@blumamir blumamir merged commit 84f43d0 into master Nov 12, 2021
@blumamir blumamir deleted the deprecate-instrumentation-aws-sdk branch November 12, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanivD YanivD YanivD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blumamir @YanivD