Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade otel versions #272

Merged
merged 11 commits into from
May 16, 2024
Merged

upgrade otel versions #272

merged 11 commits into from
May 16, 2024

Conversation

mottibec
Copy link
Contributor

@mottibec mottibec commented May 15, 2024

This pull request contains a number of updates across the codebase, primarily focused on upgrading dependencies and adjusting code to align with these updates. The changes span across multiple files, including GitHub workflow files, package.json files in various directories, and several TypeScript files.

The key changes can be grouped into three main categories:

1. Updates to GitHub workflow files:

  • .github/workflows/daily-test.yml and .github/workflows/test.yml: The Neo4j image version was updated from 4.2.3 to 4.4.34, and the NEO4J_AUTH environment variable was changed from neo4j/test to neo4j/your_password. Additionally, the Node.js version used was updated from 14 to 18. [1] [2] [3]

2. Updates to package.json files:

  • Multiple package.json files in various directories (detectors/node/resource-detector-deployment, detectors/node/resource-detector-git, detectors/node/resource-detector-service, detectors/resource-detector-sync-api, packages/instrumentation-elasticsearch, packages/instrumentation-express): These files saw updates to their dependencies, with versions of @opentelemetry/api, @opentelemetry/resources, @opentelemetry/semantic-conventions, ts-node, and typescript being updated. The opentelemetry-instrumentation-mocha dependency was replaced with aspecto-opentelemetry-instrumentation-mocha. [1] [2] [3] [4] [5] [6]
  • lerna.json and package.json at the root level: The useWorkspaces property was removed from lerna.json, and the postinstall script and the version of prettier were updated in package.json. [1] [2]

3. Updates to TypeScript files:

  • packages/instrumentation-elasticsearch/src/elasticsearch.ts and packages/instrumentation-elasticsearch/src/utils.ts: These files saw changes to the import statements for SemanticAttributes from @opentelemetry/semantic-conventions, replacing them with specific semantic attributes. There were also several changes in the ElasticsearchInstrumentation class and the startSpan and getNetAttributes functions to use the new semantic attributes. [1] [2] [3] [4] [5] [6] [7]
  • packages/instrumentation-elasticsearch/test/utils.spec.ts: The import statement for SemanticAttributes was updated, and the test cases were adjusted to use the new semantic attributes. [1] [2] [3]

@mottibec mottibec requested a review from a team as a code owner May 15, 2024 16:08
@mottibec mottibec changed the title try to upgrade otel versions upgrade otel versions May 16, 2024
@mottibec mottibec merged commit acdc802 into master May 16, 2024
3 of 4 checks passed
@mottibec mottibec deleted the motti/upgrade-otel-core branch May 16, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants