Move isUnmodifiable assertion to Iterables
#3160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract finding mutating methods into a separate class, MutatingMethodFinder which just looks for mutating methods in collections. Add unit tests for MutatingMethodFinder which test all of the mutating methods in the supported collection types. Move the assertion up from AbstractCollectionAssert to AbstractIterableAssert. see: assertj#2974
Add isUnmodifiable() back to AbstractCollectionAssert for binary compatibility.
If a collection is empty, it doesn't matter what methods like clear() and remove() do, when checking whether the collection is modifiable. As long as it isn't possible to add anything, the collection will never contain any elements. This matters because throwing UnsupportedOperationException is optional. If a collection is empty, remove() can either do nothing or throw UnsupportedOperationException. So if the collection being tested for unmodifiability is empty, calling remove() doesn't tell you anything about whether the collection is modifiable. The current approach is to have lists of pre-approved unmodifiable collections, but this won't work for collections that aren't one of the known collections but use no-op for things like remove().
scordio
changed the title
isUnmodifiable assertion to Iterables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract finding mutating methods into a separate class,
MutatingMethodFinder which just looks for mutating methods in collections.
Add unit tests for MutatingMethodFinder which test all of the mutating
methods in the supported collection types.
Move the assertion up from AbstractCollectionAssert to
AbstractIterableAssert.
see: #2974