Add hasPermittedSubclasses for Class assertions #3316
Conversation
| * @throws AssertionError if {@code actual} is {@code null}. | ||
| * @throws AssertionError if the actual {@code Class} has any permitted subclasses | ||
| */ | ||
| public SELF hasNoPermittedSubclasses() { |
There was a problem hiding this comment.
I had the impression it's not valuable to have this assertion (#3263 (comment)).
Or did I misunderstand?
There was a problem hiding this comment.
Looks like I misunderstood. When you said:
I propose we add only hasPermittedSubclasses with contains behavior
I thought you mean add hasPermittedSubclasses and do not add hasOnlyPermittedSubclasses.
I can remove this assertion, no problem.
| * @throws AssertionError if {@code actual} is {@code null}. | ||
| * @throws AssertionError if the actual {@code Class} does not have all of these permitted subclasses. | ||
| */ | ||
| public void assertContainsPermittedSubclasses(AssertionInfo info, Class<?> actual, |
There was a problem hiding this comment.
This can be pulled to AbstractClassAssert as a private method as it's unlikely we would reuse this elsewhere. hasSuperclass implementation might be a good example of such a pattern.
...va-17/src/test/java/org/assertj/core/tests/java17/Assertions_assertThat_with_Class_Test.java
Show resolved
Hide resolved
|
I'd suggest either rebase or merge but it's totally up to you. We'll anyway squash the changes in a single commit once ready. |
…rc/test/java/org/assertj/core/tests/java17/Assertions_assertThat_with_Class_Test.java Co-authored-by: Stefano Cordio <stefano_cordio@epam.com>
…rc/test/java/org/assertj/core/tests/java17/Assertions_assertThat_with_Class_Test.java Co-authored-by: Stefano Cordio <stefano_cordio@epam.com>
pbacz
changed the title
Check List:
hasPermittedSubclassesandhasNoPermittedSubclassesforClassassertions #3263