Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate OptionalDouble value comparison to Double.compare in hasValue assertion #3411

Closed
wants to merge 1 commit into from
Closed

Delegate OptionalDouble value comparison to Double.compare in hasValue assertion #3411

wants to merge 1 commit into from

Conversation

pbacz
Copy link
Contributor

@pbacz pbacz commented Apr 2, 2024

Check List:

@joel-costigliola joel-costigliola self-requested a review May 3, 2024 22:05
@scordio
Copy link
Member

scordio commented May 4, 2024

Superseded by f086a92.

@scordio scordio closed this May 4, 2024
@scordio scordio added this to the 3.26.0 milestone May 4, 2024
@scordio scordio changed the title Fix: AbstractOptionalDoubleAssert.hasValue(double) fails with NaN Delegate OptionalDouble value comparison to Double.compare May 4, 2024
@scordio scordio changed the title Delegate OptionalDouble value comparison to Double.compare Delegate OptionalDouble value comparison to Double.compare in hasValue assertion May 4, 2024
@scordio scordio added the type: breaking change A change that modifies the behavior of an existing feature label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joel-costigliola joel-costigliola Awaiting requested review from joel-costigliola

Assignees
No one assigned
Labels
type: breaking change A change that modifies the behavior of an existing feature
Projects
None yet
Milestone
3.26.0
Development

Successfully merging this pull request may close these issues.

AbstractOptionalDoubleAssert.hasValue(double) fails with NaN
2 participants
@pbacz @scordio