Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unnecessary activation event #439

Merged
merged 1 commit into from
Apr 10, 2024
Merged

refactor: remove unnecessary activation event #439

merged 1 commit into from
Apr 10, 2024

Conversation

hamirmahal
Copy link
Contributor

Summary

This change removes "onCommand:ruff.restart" from "activationEvents", because VSCode generates it automatically from package.json contribution declarations.

Test Plan

CI

hamirmahal
hamirmahal commented Apr 3, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@MichaReiser
Copy link
Member

@snowsignal would you mind taking a look at this?

@snowsignal snowsignal merged commit 5df2283 into astral-sh:main Apr 10, 2024
6 checks passed
@hamirmahal hamirmahal deleted the refactor/remove-unnecessary-activation-event branch April 11, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snowsignal snowsignal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hamirmahal @MichaReiser @snowsignal