Explicitly ban overriding extend
as part of a --config flag
#10135
+74
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #10035. Attempting to override
extend
as part of a --config flag doesn't work because we currently apply the configuration overrides given in the--config
flag after any configuration options found in anypyproject.toml
/ruff.toml
files have been parsed and validated. But this particular override affects which config files ruff should be looking at in the first place, so we'd need to look for it at an earlier stage in the process.Currently we just silently accept the argument but just don't do anything with it; this PR changes that so that we explicitly error out if a user tries to override
extend
using the--config
flag. Longer term, we could possibly think about reworking how--config
works so that it is possible to overrideextend
using--config
; or, we could add a separate option so that people can overrideextend
properly via the command line.Test Plan
cargo test
, and manual testing