Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track conditional deletions in the semantic model #10415

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Summary

Given del X, we'll typically add a BindingKind::Deletion to X to shadow the current binding. However, if the deletion is inside of a conditional operation, we won't, as in:

def f():
    global X

    if X > 0:
        del X

We will, however, track it as a reference to the binding. This PR adds the expression context to those resolved references, so that we can detect that the X in global X was "assigned to".

Closes #10397.

@charliermarsh charliermarsh added the bug Something isn't working label Mar 15, 2024
@charliermarsh charliermarsh marked this pull request as ready for review March 15, 2024 00:23
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh merged commit 10ace88 into main Mar 15, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/del branch March 15, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyLint false positive PLW0602 when del a global
1 participant