Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Q000, Q001 when string is inside forward ref #10585

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

dhruvmanila
Copy link
Member

Summary

This is not the holistic solution but just to fix that issue.

fixes: #10546

Test Plan

Add a regression test for it and check the snapshots.

@dhruvmanila dhruvmanila added the bug Something isn't working label Mar 25, 2024
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense as a quick fix 👍

@dhruvmanila dhruvmanila enabled auto-merge (squash) March 25, 2024 18:44
@dhruvmanila dhruvmanila merged commit 4950ca4 into main Mar 25, 2024
17 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/ignore-in-forward-ref branch March 25, 2024 18:53
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Q000-Q002 started to cause panic
2 participants