Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise SemanticModel::match_builtin_expr #11001

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Optimise SemanticModel::match_builtin_expr #11001

merged 1 commit into from
Apr 17, 2024

Conversation

AlexWaygood
Copy link
Member

Short-circuit more aggressively if builtins has not been imported

@AlexWaygood AlexWaygood added the internal An internal refactor or improvement label Apr 17, 2024
@AlexWaygood
Copy link
Member Author

Added the internal flag as I don't expect this to improve performance relative to the last release (but it hopefully should improve performance relative to main)

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Apr 17, 2024 •
edited

Performance is a wash overall on Codspeed, but some benchmarks have a 1% speedup. But maybe it helps with the perf problems in #10965?

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@AlexWaygood AlexWaygood merged commit caae8d2 into astral-sh:main Apr 17, 2024
17 checks passed
@AlexWaygood AlexWaygood deleted the short-circuit-more branch April 17, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexWaygood @charliermarsh