-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruff server
: Support a custom TOML configuration file
#11140
ruff server
: Support a custom TOML configuration file
#11140
Conversation
ruff server
supports a custom TOML configuration fileruff server
: support a custom TOML configuration file
ruff server
: support a custom TOML configuration fileruff server
: Support a custom TOML configuration file
dc86642
to
39f1905
Compare
|
In the absence of a project configuration for ruff, will the LS load the seetings from |
It should yes -- not sure if it does yet though @snowsignal? |
@GaetanLepage @charliermarsh I actually don't think we do this, yet - I've filed an issue to support this. |
…ation TOML file
39f1905
to
a266d05
Compare
…figuration
3a1c00b
to
1e944ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one suggestion to simplify the implementation and semantics.
Summary
Closes #10985.
The server now supports a custom TOML configuration file as a client setting. The setting must be an absolute path to a file. If the file is called
pyproject.toml
, the server will attempt to parse it as a pyproject file - otherwise, it will attempt to parse it as aruff.toml
file, even if the file has a name besidesruff.toml
.If an option is set in both the custom TOML configuration file and in the client settings directly, the latter will be used.
Test Plan
ruff.toml
file outside of the workspace you are testing. Set an option that is different from the one in the configuration for your test workspace.