Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize redefined-while-unused over unused-import #11173

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Prioritize redefined-while-unused over unused-import #11173

merged 1 commit into from
Apr 27, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Apr 27, 2024 •
edited

Summary

This PR adds an override to the fixer to ensure that we apply any redefined-while-unused fixes prior to unused-import.

Closes #10905.

@charliermarsh charliermarsh added bug Something isn't working fixes Related to suggested fixes for violations labels Apr 27, 2024
@charliermarsh charliermarsh marked this pull request as ready for review April 27, 2024 12:58
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

AlexWaygood
AlexWaygood approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@charliermarsh charliermarsh merged commit ec3243a into main Apr 27, 2024
18 checks passed
@charliermarsh charliermarsh deleted the charlie/F branch April 27, 2024 15:44
@BrewTestBot BrewTestBot mentioned this pull request May 4, 2024
Merged
@dhruvmanila dhruvmanila mentioned this pull request May 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F401 + F811 - auto-fix removes both top the level import and any inside-function import
2 participants
@charliermarsh @AlexWaygood