Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] resolve base class types #11178

Merged
merged 3 commits into from
Apr 29, 2024
Merged

[red-knot] resolve base class types #11178

merged 3 commits into from
Apr 29, 2024

Conversation

carljm
Copy link
Contributor

@carljm carljm commented Apr 27, 2024

Summary

Resolve base class types, as long as they are simple names.

Test Plan

cargo test

Copy link
Contributor

github-actions bot commented Apr 27, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@carljm carljm force-pushed the cjm/record-deps branch 2 times, most recently from 6e90d90 to 1bbe92e Compare April 27, 2024 16:22
@MichaReiser MichaReiser added the internal An internal refactor or improvement label Apr 27, 2024
crates/red_knot/src/types.rs Outdated Show resolved Hide resolved
crates/red_knot/src/types/infer.rs Outdated Show resolved Hide resolved
crates/red_knot/src/types/infer.rs Outdated Show resolved Hide resolved
@carljm carljm changed the base branch from cjm/record-deps to main April 29, 2024 21:29
## Summary

Follow simple assignments in type resolution.

## Test Plan

cargo test
@carljm carljm merged commit ce030a4 into main Apr 29, 2024
19 checks passed
@carljm carljm deleted the cjm/follow-class branch April 29, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants