[red-knot] follow simple assignments #11181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
approved these changes
Apr 27, 2024
Comment on lines
+86
to
+92
| let parsed = db.parse(file_id); | ||
| let ast = parsed.ast(); | ||
| let node = node_key.resolve_unwrap(ast.as_any_node_ref()); |
There was a problem hiding this comment.
I can see how resolving definitions might become expensive 😆
There was a problem hiding this comment.
Yes, it would be awesome if we could directly reference AST nodes instead of having to search to resolve :/
|
|
You know have to label your PRs or they'll show up in the changelog 😆 |
|
Ugh, yes I know, I did remember to label one of them today! #11176 |
|
I think I would have remembered before merging :) |
carljm
force-pushed
the
cjm/follow-class
branch
from
d47e9ee
to
c21002d
Compare
carljm
force-pushed
the
cjm/follow-assign
branch
from
64620b5
to
42eec9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow simple assignments in type resolution.
Test Plan
cargo test