Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write ruff server setup guide for Helix #11183

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

snowsignal
Copy link
Member

Summary

Closes #11027.

@snowsignal snowsignal added documentation Improvements or additions to documentation server Related to the LSP server labels Apr 28, 2024
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some nice features in the existing Helix setup guide that we should replicate here (https://github.com/astral-sh/ruff-lsp?tab=readme-ov-file#example-helix):

  • auto-format = true?
  • Demonstrating how to configure it ([language-server.ruff.config.settings])
  • Including a screenshot of the editor once you've reached the success state

crates/ruff_server/docs/setup/HELIX.md Outdated Show resolved Hide resolved
crates/ruff_server/docs/setup/HELIX.md Show resolved Hide resolved
@snowsignal snowsignal force-pushed the jane/server/editors/helix/setup branch from 55fee83 to d91a5d7 Compare April 29, 2024 16:30
Copy link
Contributor

github-actions bot commented Apr 29, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

crates/ruff_server/docs/setup/HELIX.md Show resolved Hide resolved
crates/ruff_server/docs/setup/HELIX.md Show resolved Hide resolved
crates/ruff_server/docs/setup/HELIX.md Show resolved Hide resolved
@snowsignal snowsignal force-pushed the jane/server/editors/helix/setup branch from 5db4e06 to 9982400 Compare April 30, 2024 14:58
@snowsignal snowsignal merged commit 4779dd1 into main Apr 30, 2024
19 checks passed
@snowsignal snowsignal deleted the jane/server/editors/helix/setup branch April 30, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation server Related to the LSP server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ruff server add setup guide for helix editor
3 participants