Ignore list-copy recommendations for async for loops
#11250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
approved these changes
May 2, 2024
|
Nice! |
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PERF401 | 2 | 2 | 0 | 0 | 0 |
| PERF402 | 2 | 0 | 2 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+2 -2 violations, +0 -0 fixes in 1 projects; 43 projects unchanged)
apache/airflow (+2 -2 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ airflow/providers/microsoft/azure/hooks/wasb.py:690:13: PERF401 Use an async list comprehension to create a transformed list - airflow/providers/microsoft/azure/hooks/wasb.py:690:13: PERF402 Use `list` or `list.copy` to create a copy of a list + tests/providers/microsoft/azure/base.py:55:13: PERF401 Use an async list comprehension to create a transformed list - tests/providers/microsoft/azure/base.py:55:13: PERF402 Use `list` or `list.copy` to create a copy of a list
Changes by rule (2 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PERF401 | 2 | 2 | 0 | 0 | 0 |
| PERF402 | 2 | 0 | 2 | 0 | 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes these from
PERF402, but adds them toPERF401, with a custom message to use anasynccomprehension.Closes #10787.