Avoid allocations for isort module names #11251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
May 2, 2024
Comment on lines
722
to
724
| let mut module_name = String::with_capacity( | ||
| (level as usize) + module.as_ref().map_or(0, |module| module.len()), | ||
| ); |
zanieb
approved these changes
May 2, 2024
charliermarsh
force-pushed
the
charlie/cow
branch
2 times, most recently
from
dd402ec
to
ee597c6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Random refactor I noticed when investigating the F401 changes. We don't need to allocate in most cases here.