Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore end-of-line comments when determining blank line rules #11342

Merged
merged 1 commit into from
May 8, 2024
Merged

Ignore end-of-line comments when determining blank line rules #11342

merged 1 commit into from
May 8, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #11331.

@charliermarsh charliermarsh added bug Something isn't working preview Related to preview mode features labels May 8, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) May 8, 2024 15:17
@charliermarsh charliermarsh merged commit 8e9ddee into main May 8, 2024
19 checks passed
@charliermarsh charliermarsh deleted the charlie/comm branch May 8, 2024 15:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@BrewTestBot BrewTestBot mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
bug Something isn't working preview Related to preview mode features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[preview][E302] False positive in overload when comment added
2 participants
@charliermarsh @MichaReiser