Remove empty line before raw dostrings #7944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** This fixes a deviation with black where black would remove empty lines before raw docstrings for some reason.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
There was a problem hiding this comment.
I think Black treats this as "not a docstring" -- it does the same thing with non-triple-quoted strings in docstring positions, so e.g., it removes the newline here:
class C:
"abc"My opinion would be to keep our current behavior, because we do treat such non-triple-quoted strings as docstrings unlike Black, so treating the raw strings as docstrings is more internally consistent for us (and feels like a bug in Black).
|
Reported upstream: psf/black#3944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary This fixes a deviation with black where black would remove empty lines before raw docstrings for some reason.