Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip over parentheses when detecting in keyword #8054

Merged
merged 1 commit into from Oct 18, 2023
Merged

Skip over parentheses when detecting in keyword #8054

merged 1 commit into from Oct 18, 2023

Conversation

charliermarsh
Copy link
Member

Summary

Given an expression like [x for (x) in y], we weren't skipping over parentheses when searching for the in between (x) and y.

Closes #8053.

@charliermarsh charliermarsh added bug Something isn't working formatter Related to the formatter labels Oct 18, 2023
@charliermarsh charliermarsh merged commit 2729c4c into main Oct 18, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/if branch October 18, 2023 23:13
@p-linnane p-linnane mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@konstin konstin Awaiting requested review from konstin

Assignees
No one assigned
Labels
bug Something isn't working formatter Related to the formatter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] [formatter] parenthesized single list comp var chokes formatter
2 participants
@charliermarsh @MichaReiser