Avoid loading files for cached format results #8134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
MichaReiser
force-pushed
the
format-cache-avoid-reading-files
branch
from
8a1e37f
to
2ad7124
Compare
konstin
approved these changes
Oct 23, 2023
Comment on lines
-428
to
+434
| Diff(SourceKind), | ||
| Diff { | ||
| unformatted: SourceKind, | ||
| formatted: SourceKind, | ||
| }, | ||
| /// The file was unchanged, as the formatted contents matched the existing contents. | ||
| Unchanged, | ||
|
|
||
| /// Skipped formatting because its an unformatted file format | ||
| Skipped, |
There was a problem hiding this comment.
This was easier than i expected
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid loading the content of cached files during formatting
Test Plan
Closes #8132
Performance
This reduces the runtime for a hot formatting on airflow from ~105ms to ~90ms
Thanks @konstin for the find.