Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add auto-fix for E225,226,227,228 #8136

Merged
merged 3 commits into from Oct 23, 2023
Merged

add auto-fix for E225,226,227,228 #8136

merged 3 commits into from Oct 23, 2023

Conversation

reswqa
Copy link
Contributor

@reswqa reswqa commented Oct 23, 2023 •
edited

Summary

Introduce auto fix for E225,E226,E227,E228. This partially address #8121.

Test Plan

Already covered.

@reswqa reswqa marked this pull request as ready for review October 23, 2023 10:48
@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+1, -0, 0 error(s))

sphinx (+1, -0) 

+     = help: Add missing whitespace

@charliermarsh charliermarsh added the fixes Related to suggested fixes for violations label Oct 23, 2023
charliermarsh
charliermarsh approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! (The only thing I've been modifying here are the messages -- we like to keep them more succinct because they show up as Code Actions in the editor, so e.g., you already know what token you're inserting space around.)

@charliermarsh charliermarsh enabled auto-merge (squash) October 23, 2023 18:50
@charliermarsh charliermarsh merged commit 7100e12 into astral-sh:main Oct 23, 2023
15 checks passed
@p-linnane p-linnane mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reswqa @charliermarsh