Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIM112] Ignore https_proxy, http_proxy, and no_proxy #8140

Merged
merged 4 commits into from Oct 23, 2023

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Oct 23, 2023

Summary

Close #8123

Test Plan

New test cases

Signed-off-by: harupy <hkawamura0130@gmail.com>
@github-actions
Copy link

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+4, -1, 0 error(s))

zulip (+4, -1)

- [*] 7906 fixable with the `--fix` option (12150 hidden fixes can be enabled with the `--unsafe-fixes` option).
+ [*] 7909 fixable with the `--fix` option (12150 hidden fixes can be enabled with the `--unsafe-fixes` option).
+ tools/lib/provision.py:410:60: RUF100 [*] Unused `noqa` directive (unused: `SIM112`)
+ tools/lib/provision.py:411:62: RUF100 [*] Unused `noqa` directive (unused: `SIM112`)
+ tools/lib/provision.py:412:56: RUF100 [*] Unused `noqa` directive (unused: `SIM112`)

Rules changed: 1
Rule Changes Additions Removals
RUF100 3 3 0

@zanieb zanieb merged commit b9bff6f into astral-sh:main Oct 23, 2023
16 checks passed
@zanieb zanieb added the rule Implementing or modifying a lint rule label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uncapitalized-environment-variables (SIM112) false positive on https_proxy, http_proxy and no_proxy variables
3 participants