Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add auto-fix for E223,224,242 #8143

Merged
merged 4 commits into from Oct 23, 2023
Merged

add auto-fix for E223,224,242 #8143

merged 4 commits into from Oct 23, 2023

Conversation

reswqa
Copy link
Contributor

@reswqa reswqa commented Oct 23, 2023 •
edited

Summary

Introduce auto fix for E223, E224, E242. This partially address #8120.

Test Plan

Already covered.

@reswqa reswqa changed the title add auto-fix for E223,224 add auto-fix for E223,224,242 Oct 23, 2023
@reswqa
Copy link
Contributor Author

reswqa commented Oct 23, 2023

I'm not clear why CI(benchmarks) failed.

@reswqa reswqa marked this pull request as ready for review October 23, 2023 14:15
@charliermarsh charliermarsh self-requested a review October 23, 2023 16:05
@charliermarsh charliermarsh added the fixes Related to suggested fixes for violations label Oct 23, 2023
charliermarsh
charliermarsh approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh enabled auto-merge (squash) October 23, 2023 16:10
@charliermarsh charliermarsh merged commit 92baa35 into astral-sh:main Oct 23, 2023
14 of 15 checks passed
@p-linnane p-linnane mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reswqa @charliermarsh