Match rule prefixes from external codes setting in unused-noqa
#8177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zanie/external-prefix
branch
from
9379989
to
4ed19d6
Compare
zanieb
added
rule
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
| || settings | ||
| .external | ||
| .iter() | ||
| .any(|external| code.starts_with(external)) |
There was a problem hiding this comment.
Since most codes won't match an external, I bet it's better to just do this iteration every time and skip the direct check, but obviously can't say for sure.
It's probably even better to just use a vector instead of a hash set, since we're doing this iteration every time, and the set of externals is gonna tend to be quite small.
There was a problem hiding this comment.
(Defer to you as to whether you want to change.)
charliermarsh
approved these changes
Oct 24, 2023
zanieb
force-pushed
the
zanie/external-prefix
branch
from
87874f2
to
42dce59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #8176
Closes #8174
Test plan
Old snapshot contains the new / unmatched
VcodeNew snapshot contains no
Vprefixed codes