Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a wrong setting in configuration.md #8186

Merged
merged 1 commit into from Oct 24, 2023
Merged

Fix a wrong setting in configuration.md #8186

merged 1 commit into from Oct 24, 2023

Conversation

lmanc
Copy link
Contributor

@lmanc lmanc commented Oct 24, 2023

Summary

The previous configuration for ruff contained an unrecognized field magic-trailing-comma set to "respect". As of version 0.1.2 of ruff, this field was not recognized and resulted in a TOML parse error when running the ruff format . command. This change removes the magic-trailing-comma field and adds the recognized skip-magic-trailing-comma field set to false.

Test Plan

Tested locally with ruff 0.1.2.

The previous configuration for `ruff` contained an unrecognized field `magic-trailing-comma` set to "respect". As of version 0.1.2 of `ruff`, this field was not recognized and resulted in a TOML parse error when running the `ruff format .` command. This change removes the `magic-trailing-comma` field and adds the recognized `skip-magic-trailing-comma` field set to `false`.
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanieb zanieb added the documentation Improvements or additions to documentation label Oct 24, 2023
@zanieb zanieb merged commit a6cc56f into astral-sh:main Oct 24, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants