Formatter parentheses support for IpyEscapeCommand

[dhruvmanila]

Summary

This PR removes the todo!() around IpyEscapeCommand in the formatter.

The NeedsParentheses trait needs to be implemented which always return Never. The reason being that if an escape command is parenthesized, then that's not parsed as an escape command. IOW, the parentheses shouldn't be present around an escape command.

In the similar way, the CanSkipOptionalParenthesesVisitor will skip this node.

Test Plan

Updated the unformatted.ipynb fixture with new cells containing IPython escape commands and the corresponding snapshot was verified. Also, tested it out in a few open source repositories containing notebooks (openai/openai-cookbook, huggingface/notebooks).

New cells in unformatted.ipynb

Cell 2

A markdown cell

Cell 3

def some_function(foo, bar):
    pass
%matplotlib inline

Cell 4

foo = %pwd
def some_function(foo,bar,):
	foo = %pwd
    print(foo
	)

fixes: #8204

[dhruvmanila]

Current dependencies on/for this PR:

• main
  • PR Use source type to determine parser mode for formatting #8205
    • PR Formatter parentheses support for IpyEscapeCommand #8207 👈

This comment was auto-generated by Graphite.

[MichaReiser]

Looks good to me. Can we add an E2E test (CLI test) in the parent PR that tests ruff format with a notebook that contains ipython commands?

[dhruvmanila]

Can we add an E2E test (CLI test) in the parent PR that tests ruff format with a notebook that contains ipython commands?

Do you mean in this PR? I've added it.

[github-actions]

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.