Don't warn about magic trailing comma when isort.force-single-line is true
#8244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
|
(issue with |
|
(I accidentally merged in main not realizing this has a different upstream, but I'll fix it up before merging.) |
Base automatically changed from
refine-linter-incompatible-option-warnings
to
main
October 26, 2023 16:22
charliermarsh
force-pushed
the
10-26-Don_t_warn_about_magic_trailing_comma_when_isort.force-single-line_is_true
branch
from
99c944d
to
2a78ccb
Compare
charliermarsh
approved these changes
Oct 26, 2023
charliermarsh
deleted the
10-26-Don_t_warn_about_magic_trailing_comma_when_isort.force-single-line_is_true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on this feedback. Avoid warning about
force-wrap-aliasesandsplit-on-trailing-commaifforce-single-lineis true (which creates a dedicated import for each imported member).Test Plan
Ran
ruff format . --no-cacheand verified that the warning show up whenforce-single-line=falseand aren't shown whenforce-single-line=true