Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint] Implement useless-with-lock #8321

Merged
merged 6 commits into from Oct 29, 2023
Merged

[pylint] Implement useless-with-lock #8321

merged 6 commits into from Oct 29, 2023

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Oct 29, 2023

Summary

#970

Test Plan

cargo test

@github-actions
Copy link

github-actions bot commented Oct 29, 2023 •
edited

PR Check Results

Ecosystem

✅ ecosystem check detected no linter changes.

charliermarsh
charliermarsh approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Oct 29, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) October 29, 2023 16:21
@charliermarsh charliermarsh merged commit 44e21cf into astral-sh:main Oct 29, 2023
14 checks passed
@charliermarsh
Copy link
Member

Great work @harupy.

@harupy harupy deleted the PLW2101 branch October 30, 2023 00:21
@miccal miccal mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harupy @charliermarsh