Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No newline after function docstrings #8375

Merged
merged 1 commit into from Oct 31, 2023
Merged

No newline after function docstrings #8375

merged 1 commit into from Oct 31, 2023

Conversation

konstin
Copy link
Member

@konstin konstin commented Oct 31, 2023 •
edited

Fixup for #8216 to not apply to function docstrings.

Main before #8216:

project similarity index total files changed files
cpython 0.75804 1799 1648
django 0.99984 2772 33
home-assistant 0.99963 10596 148
poetry 0.99925 317 12
transformers 0.99967 2657 328
twine 1.00000 33 0
typeshed 0.99980 3669 18
warehouse 0.99977 654 13
zulip 0.99970 1459 22

main now:

project similarity index total files changed files
cpython 0.75804 1799 1648
django 0.99984 2772 48
home-assistant 0.99963 10596 181
poetry 0.99925 317 12
transformers 0.99967 2657 339
twine 1.00000 33 0
typeshed 0.99980 3669 18
warehouse 0.99977 654 13
zulip 0.99970 1459 23

PR:

project similarity index total files changed files
cpython 0.75804 1799 1648
django 0.99984 2772 33
home-assistant 0.99963 10596 148
poetry 0.99925 317 12
transformers 0.99967 2657 328
twine 1.00000 33 0
typeshed 0.99980 3669 18
warehouse 0.99977 654 13
zulip 0.99970 1459 22

@konstin
No newline after function docstrings
79084b9 
Fixup for #8216 to not apply to function docstrings.

Main before #8216:

| project        | similarity index  | total files       | changed files     |
|----------------|------------------:|------------------:|------------------:|
| cpython        |           0.75804 |              1799 |              1648 |
| django         |           0.99984 |              2772 |                33 |
| home-assistant |           0.99963 |             10596 |               148 |
| poetry         |           0.99925 |               317 |                12 |
| transformers   |           0.99967 |              2657 |               328 |
| twine          |           1.00000 |                33 |                 0 |
| typeshed       |           0.99980 |              3669 |                18 |
| warehouse      |           0.99977 |               654 |                13 |
| zulip          |           0.99970 |              1459 |                22 |

main now:

| project        | similarity index  | total files       | changed files     |
|----------------|------------------:|------------------:|------------------:|
| cpython        |           0.75804 |              1799 |              1648 |
| django         |           0.99984 |              2772 |                48 |
| home-assistant |           0.99963 |             10596 |               181 |
| poetry         |           0.99925 |               317 |                12 |
| transformers   |           0.99967 |              2657 |               339 |
| twine          |           1.00000 |                33 |                 0 |
| typeshed       |           0.99980 |              3669 |                18 |
| warehouse      |           0.99977 |               654 |                13 |
| zulip          |           0.99970 |              1459 |                23 |

PR:

| project        | similarity index  | total files       | changed files     |
|----------------|------------------:|------------------:|------------------:|
| cpython        |           0.75804 |              1799 |              1648 |
| django         |           0.99984 |              2772 |                33 |
| home-assistant |           0.99963 |             10596 |               148 |
| poetry         |           0.99925 |               317 |                12 |
| transformers   |           0.99967 |              2657 |               328 |
| twine          |           1.00000 |                33 |                 0 |
| typeshed       |           0.99980 |              3669 |                18 |
| warehouse      |           0.99977 |               654 |                13 |
| zulip          |           0.99970 |              1459 |                22 |
@konstin konstin added the formatter Related to the formatter label Oct 31, 2023
@konstin konstin mentioned this pull request Oct 31, 2023
Merged
@github-actions
Copy link

PR Check Results

Ecosystem

✅ ecosystem check detected no format changes.

charliermarsh
charliermarsh approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@charliermarsh
Copy link
Member

\cc @zanieb - Also expected ecosystem format changes here, just in case you need more examples.

@charliermarsh charliermarsh merged commit 3076d76 into main Oct 31, 2023
17 checks passed
@charliermarsh charliermarsh deleted the no-newline-after-function-docstrings branch October 31, 2023 18:32
@miccal miccal mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
formatter Related to the formatter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@konstin @charliermarsh