Fix bug where PLE1307 was raised when formatting %c with characters
#8407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Nov 1, 2023
crates/ruff_linter/resources/test/fixtures/pylint/bad_string_format_type.py
Outdated
Show resolved
Hide resolved
|
MichaReiser
approved these changes
Nov 1, 2023
| ResolvedPythonType::Atom(atom) => { | ||
| // Special case where `%c` allows single character strings to be formatted | ||
| if format.format_char == 'c' { | ||
| if let Expr::StringLiteral(string) = value { |
There was a problem hiding this comment.
Could this also be a byte string or fstring?
There was a problem hiding this comment.
Hm good idea, I checked:
print("%c" % b"x") # Runtime error
print("%c" % f"x") # OKI'm hesitant to support the format string though it's a weird use.
dhruvmanila
approved these changes
Nov 2, 2023
crates/ruff_linter/resources/test/fixtures/pylint/bad_string_format_type.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8406