Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8-trio support #8439

Merged
merged 5 commits into from Nov 3, 2023
Merged

Conversation

karpetrosyan
Copy link
Contributor

@karpetrosyan karpetrosyan commented Nov 2, 2023

Summary

This pull request adds flake8-trio support to ruff, which is a very useful plugin for trio users to avoid very common mistakes.

Part of #8451.

Test Plan

Traditional rule testing, as described in the documentation.

Copy link

github-actions bot commented Nov 2, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh self-requested a review November 2, 2023 13:58
@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some small comments.

@charliermarsh
Copy link
Member

Thanks! I also created #8451 to track flake8-trio.

@charliermarsh charliermarsh merged commit 2ff1afb into astral-sh:main Nov 3, 2023
16 checks passed
Copy link

github-actions bot commented Nov 3, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants