Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect local subclasses in flake8-type-checking #8768

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

charliermarsh
Copy link
Member

If you define a subclass of pydantic.BaseModel, and then a subclass of that class in the same file, we'll now correctly treat it as runtime-evaluated.

Closes #7893.

@charliermarsh charliermarsh added the bug Something isn't working label Nov 19, 2023
@charliermarsh charliermarsh force-pushed the charlie/pyi branch 2 times, most recently from f0a1a0c to a1eba7f Compare November 19, 2023 14:40
@charliermarsh charliermarsh merged commit 00a015c into main Nov 19, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/pyi branch November 19, 2023 14:49
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete resolving of subclass chains in runtime-evaluated-base-classes
1 participant