Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIE796] don't report when using ellipses for enum values in stub files #8825

Merged
merged 2 commits into from
Nov 24, 2023
Merged

[PIE796] don't report when using ellipses for enum values in stub files #8825

merged 2 commits into from
Nov 24, 2023

Conversation

sciyoshi
Copy link
Contributor

Summary

Just ignores ellipses as enum values inside stub files.

Fixes #8818.

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh
Copy link
Member

Thanks!

@charliermarsh charliermarsh merged commit 852a8f4 into astral-sh:main Nov 24, 2023
17 checks passed
@sciyoshi sciyoshi deleted the pie796-stub-ellipsis branch November 24, 2023 15:29
@miccal miccal mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive in PYI files with ellipsis for PIE796
3 participants
@sciyoshi @charliermarsh @konstin