Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid filtering out un-representable types in return annotation #8881

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

charliermarsh
Copy link
Member

Summary

Given Union[Dict, None] (in our internal representation), we were filtering out Dict since we treat it as un-representable (i.e., we can't convert it to an expression), returning just None as the type annotation. We should require that all members of the union are representable.

Closes #8879.

@charliermarsh charliermarsh added the bug Something isn't working label Nov 28, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) November 28, 2023 21:06
@charliermarsh charliermarsh merged commit 4126888 into main Nov 28, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/an branch November 28, 2023 21:10
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsafe fix for ANN2XX is too unsafe
1 participant